Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aatch's cfg revisions, namely to match expressions #22580

Merged
merged 5 commits into from
Feb 24, 2015

Conversation

pnkfelix
Copy link
Member

aatch's cfg revisions, namely to match expressions

Revise handling of match expressions so that arms branch to next arm.

Update the graphviz tests accordingly.

Fixes #22073. (Includes regression test for the issue.)

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix
Copy link
Member Author

@bors r=pnkfelix e5c65c2

@Manishearth
Copy link
Member

(needs rebase)

(Factoring of aatch CFG code, Part 1.)
(Factoring of aatch CFG code, Part 2.)
This is necessary for e.g. supporting the cfgs we plan to construct
for match under aatch's plan.

(Factoring of aatch CFG code, Part 3.)
Update the graphviz tests accordingly.

Fixes rust-lang#22073. (Includes regression test for the issue.)

(Factoring of aatch CFG code, Part 4.)
@pnkfelix
Copy link
Member Author

@bors: r+ 85defff

@goffrie
Copy link
Contributor

goffrie commented Feb 23, 2015

This is technically a [breaking-change], no?

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 24, 2015
 aatch's cfg revisions, namely to match expressions

Revise handling of match expressions so that arms branch to next arm.

Update the graphviz tests accordingly.

Fixes rust-lang#22073. (Includes regression test for the issue.)
@bors bors merged commit 85defff into rust-lang:master Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moves in guard expressions aren't handled properly
7 participants